Skip to content

Fix typos in share/minizinc #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.82%. Comparing base (fb83a2f) to head (e4cc2e5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #204   +/-   ##
========================================
  Coverage    75.82%   75.82%           
========================================
  Files          124      124           
  Lines        42242    42242           
  Branches     42242    42242           
========================================
  Hits         32028    32028           
  Misses        9490     9490           
  Partials       724      724           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waywardmonkeys
Copy link
Contributor Author

@Dekker1 I rebased this forward now that you fixed clippy and stuff.

@Dekker1
Copy link
Contributor

Dekker1 commented Oct 15, 2024

Thank you for the PR. We have been talking for a while about how to keep the MiniZinc library consistent with the current system (https://github.com/MiniZinc/libminizinc). Likely we will switch to a system where this repository will only contain overrides for new features, and we will maintain the MiniZinc library in the other repository. As such, I won't merge these changes, but would suggest that you rebase them on the other repository and make a PR there.

Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants